Component Viewer initial commit#725
Merged
Merged
Conversation
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
jreineckearm
reviewed
Jan 9, 2026
Collaborator
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
Reviewed first couple of files, main focus on previously existing ones. See individual comments.
evaluateFormatSegmentValue now skips reference recovery when the printf subexpression fully folds to a constant (constValue present), avoiding grabbing containers from non-executed branches.
* change component viewer icon to custom icon * updating GUI at various events and removing unneeded code * refactoring scvd and svd files paths functions to a single function * fixing a typo --------- Co-authored-by: Thorsten de Buhr <thorsten.deBuhr@arm.com>
Co-authored-by: Thorsten de Buhr <thorsten.deBuhr@arm.com>
* refactoring private variables location in controller class * removing extra layer of componentViewer main and changing controller name to main * updating tests and files in accordance with new class names --------- Co-authored-by: Thorsten de Buhr <thorsten.deBuhr@arm.com>
* removed old test file that is not needed * removing unneeded test file --------- Co-authored-by: Thorsten de Buhr <thorsten.deBuhr@arm.com>
jreineckearm
approved these changes
Jan 21, 2026
Collaborator
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @thorstendb-ARM and @omarArm ! I know this was (and still is) a huge piece of work.
Code review completed, critical feedback has been addressed. Let's continue to work through the remaining list of feedback items as we go.
Manual testing of the changes showed issues regarding refresh triggers. And window updates after disconnecting/reconnecting. Work on this is in progress in #752 .
Since we now have reached a good first baseline of code quality and automated tests, I am good to merge this PR despite the known issues. Confidence is high that we can fix the remaining problems quickly until the next scheduled release. Hence I rather have this in for easy early testing and accept that the view isn't fully operational yet. This also allows from now on code reviews with smaller and more focused increments, and hence more stabilized functionality going forward.
omarArm
added a commit
that referenced
this pull request
Jan 22, 2026
* Component Viewer initial commit --------- Authored-by: Thorsten de Buhr <thorsten.deBuhr@arm.com> Co-authored-by: Omar Elkhouly <omar.elkhouly@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
Checklist